Posted by Jason Cohen on Wednesday, December 03, 2008

Smart Bear founder Jason Cohen literally wrote the book on code reviews. So if you have any questions about code review, Smart Bear, or Code Collaborator, email Jason. Your question may be answered in a future blog entry.

When you start a review you don't always know -- or care -- who the reviewer should be.  There might be five people who are qualified to do the review, but you don't know their schedules.  Are they stuck in meetings all day?  Who is already assigned to four other reviews?  Who is under a deadline and can't do a review right now?  Who has lots of free time and would like nothing more than to review your code?

OK maybe that last one.  Still, it would be nice to be able to assign a review to a set of people -- a "review pool" -- with the idea that one of them will actually do the review.

But how do you do that with Code Collaborator, and what are the pitfalls of this technique?

Start by setting up a review pool user account.  This is just a regular user account, except the email address is a list of email addresses of everyone in the pool.  (Or, set up an email alias on your mail server for the same effect but a different point of control.)

Then, when you've created a review, assign the review pool user as the reviewer.  When the review starts, everyone in the pool will get the email.

To "take" a review as one of the reviewers, open the review and click the "Edit" button in the "Participants" toolbar.  Just replace the pool user with your own name.  Or, leave the pool user in and add your name; this is good if you want to keep the audit trail of which review pool this review was originally assigned to.

Of course you can create as many review pool users as you need for different groups and purposes.

Enjoy!

P.S. Before you ask, pool users will not count against your purchased licenses because these users never log in.  You can enforce this by configuring some horrible, random password for that account that no one -- not even you -- would guess.

Share this blog post:
  • Facebook
  • DZone It!
  • Digg It!
  • Del.icio.us
  • Reddit
  • Twitter
  • Email It!

Comments  5

Gravatar
  • Julian Ratcliffe 02/12/2009 02:06 AM

    How should we set up pool accounts if we are using Active Directory and cannot add Code Collaborator users at will?
    "Because you're using an external authentication mechanism, you cannot create new users from the web interface. New accounts will be created automatically as users log in for the first time."

     
    Gravatar
  • Jason Cohen 02/13/2009 00:01 AM

    @Julan
    Thanks.

     
    Gravatar
  • Julian Ratcliffe 02/16/2009 01:53 AM

    If we switch authentication methods does the Code Collaborator user list get wiped out? If it isn’t, we could switch out Active Directory, create the user pool accounts, and switch back perhaps?

     
    Gravatar
  • Jason Cohen 02/16/2009 05:53 AM

    @Julian

     
    Gravatar
  • Gregg Sporar 07/12/2010 10:06 AM

    With the ability added to create a user with the ccollab command line utility, this review pool technique *will* now work even in an environment where Code Collaborator is configured to use LDAP.

     

    Leave a comment:

    1.    
       
       
       
       
         
     

    +1 978-236-7900

    © 2012 SmartBear Software. All rights reserved.
    Home | Privacy | Terms of Use | About | Contact Us | Site Map | Print